From 61ec1edb35d73580504806d11b19100651435b07 Mon Sep 17 00:00:00 2001 From: Natanel Shitrit <65548905+Natanel-Shitrit@users.noreply.github.com> Date: Sun, 28 Jan 2024 15:01:29 +0200 Subject: [PATCH] feat: start player maximized pref (#637) --- .../java/dev/jdtech/jellyfin/utils/PlayerGestureHelper.kt | 2 ++ core/src/main/res/values/strings.xml | 2 ++ core/src/main/res/xml/fragment_settings_player.xml | 5 +++++ .../src/main/java/dev/jdtech/jellyfin/AppPreferences.kt | 3 +++ preferences/src/main/java/dev/jdtech/jellyfin/Constants.kt | 1 + 5 files changed, 13 insertions(+) diff --git a/app/phone/src/main/java/dev/jdtech/jellyfin/utils/PlayerGestureHelper.kt b/app/phone/src/main/java/dev/jdtech/jellyfin/utils/PlayerGestureHelper.kt index 9591abef..e647e9cd 100644 --- a/app/phone/src/main/java/dev/jdtech/jellyfin/utils/PlayerGestureHelper.kt +++ b/app/phone/src/main/java/dev/jdtech/jellyfin/utils/PlayerGestureHelper.kt @@ -418,6 +418,8 @@ class PlayerGestureHelper( activity.window.attributes.screenBrightness = appPreferences.playerBrightness } + updateZoomMode(appPreferences.playerStartMaximized) + @Suppress("ClickableViewAccessibility") playerView.setOnTouchListener { _, event -> if (playerView.useController) { diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml index ec8684c0..1ce1def7 100644 --- a/core/src/main/res/values/strings.xml +++ b/core/src/main/res/values/strings.xml @@ -107,6 +107,8 @@ Pinch to fill the screen with the video Swipe horizontally to seek forwards or backwards Remember brightness level + Start maximized + Open video in maximized mode by default Title IMDB Rating Parental Rating diff --git a/core/src/main/res/xml/fragment_settings_player.xml b/core/src/main/res/xml/fragment_settings_player.xml index ac367054..495e0388 100644 --- a/core/src/main/res/xml/fragment_settings_player.xml +++ b/core/src/main/res/xml/fragment_settings_player.xml @@ -63,6 +63,11 @@ app:dependency="pref_player_gestures_vb" app:key="pref_player_brightness_remember" app:title="@string/player_brightness_remember" /> + diff --git a/preferences/src/main/java/dev/jdtech/jellyfin/AppPreferences.kt b/preferences/src/main/java/dev/jdtech/jellyfin/AppPreferences.kt index 155b23fc..132e3c5d 100644 --- a/preferences/src/main/java/dev/jdtech/jellyfin/AppPreferences.kt +++ b/preferences/src/main/java/dev/jdtech/jellyfin/AppPreferences.kt @@ -51,6 +51,9 @@ constructor( val playerBrightnessRemember get() = sharedPreferences.getBoolean(Constants.PREF_PLAYER_BRIGHTNESS_REMEMBER, false) + val playerStartMaximized get() = + sharedPreferences.getBoolean(Constants.PREF_PLAYER_START_MAXIMIZED, false) + var playerBrightness: Float get() = sharedPreferences.getFloat( Constants.PREF_PLAYER_BRIGHTNESS, diff --git a/preferences/src/main/java/dev/jdtech/jellyfin/Constants.kt b/preferences/src/main/java/dev/jdtech/jellyfin/Constants.kt index b34d6313..89403118 100644 --- a/preferences/src/main/java/dev/jdtech/jellyfin/Constants.kt +++ b/preferences/src/main/java/dev/jdtech/jellyfin/Constants.kt @@ -17,6 +17,7 @@ object Constants { const val PREF_PLAYER_GESTURES_ZOOM = "pref_player_gestures_zoom" const val PREF_PLAYER_GESTURES_SEEK = "pref_player_gestures_seek" const val PREF_PLAYER_BRIGHTNESS_REMEMBER = "pref_player_brightness_remember" + const val PREF_PLAYER_START_MAXIMIZED = "pref_player_start_maximized" const val PREF_PLAYER_BRIGHTNESS = "pref_player_brightness" const val PREF_PLAYER_SEEK_BACK_INC = "pref_player_seek_back_inc" const val PREF_PLAYER_SEEK_FORWARD_INC = "pref_player_seek_forward_inc"