From 7a3b67f64b2680bdac939fed70a32c377cdde0f9 Mon Sep 17 00:00:00 2001
From: Jarne Demeulemeester <jarnedemeulemeester@gmail.com>
Date: Sun, 9 Jul 2023 15:15:15 +0200
Subject: [PATCH] fix(player): playback position reset on process death and
 playback continues playing when the device is locked

Closes #389 #390
---
 app/phone/src/main/AndroidManifest.xml        |  1 +
 .../dev/jdtech/jellyfin/BasePlayerActivity.kt |  1 +
 .../dev/jdtech/jellyfin/PlayerActivity.kt     |  2 --
 .../viewmodels/PlayerActivityViewModel.kt     | 26 ++++++++++++++-----
 4 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/app/phone/src/main/AndroidManifest.xml b/app/phone/src/main/AndroidManifest.xml
index b3509ff5..57840a31 100644
--- a/app/phone/src/main/AndroidManifest.xml
+++ b/app/phone/src/main/AndroidManifest.xml
@@ -24,6 +24,7 @@
 
         <activity
             android:name=".PlayerActivity"
+            android:configChanges="screenSize|smallestScreenSize|screenLayout|orientation"
             android:screenOrientation="sensorLandscape" />
 
         <activity
diff --git a/app/phone/src/main/java/dev/jdtech/jellyfin/BasePlayerActivity.kt b/app/phone/src/main/java/dev/jdtech/jellyfin/BasePlayerActivity.kt
index 144efc6c..7ba01193 100644
--- a/app/phone/src/main/java/dev/jdtech/jellyfin/BasePlayerActivity.kt
+++ b/app/phone/src/main/java/dev/jdtech/jellyfin/BasePlayerActivity.kt
@@ -30,6 +30,7 @@ abstract class BasePlayerActivity : AppCompatActivity() {
 
     override fun onPause() {
         super.onPause()
+
         viewModel.playWhenReady = viewModel.player.playWhenReady == true
         viewModel.player.playWhenReady = false
     }
diff --git a/app/phone/src/main/java/dev/jdtech/jellyfin/PlayerActivity.kt b/app/phone/src/main/java/dev/jdtech/jellyfin/PlayerActivity.kt
index 413ab7b6..09a80342 100644
--- a/app/phone/src/main/java/dev/jdtech/jellyfin/PlayerActivity.kt
+++ b/app/phone/src/main/java/dev/jdtech/jellyfin/PlayerActivity.kt
@@ -27,7 +27,6 @@ import dev.jdtech.jellyfin.mpv.TrackType
 import dev.jdtech.jellyfin.utils.PlayerGestureHelper
 import dev.jdtech.jellyfin.utils.PreviewScrubListener
 import dev.jdtech.jellyfin.viewmodels.PlayerActivityViewModel
-import timber.log.Timber
 import javax.inject.Inject
 import dev.jdtech.jellyfin.player.video.R as PlayerVideoR
 
@@ -46,7 +45,6 @@ class PlayerActivity : BasePlayerActivity() {
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        Timber.d("Creating player activity")
 
         binding = ActivityPlayerBinding.inflate(layoutInflater)
         setContentView(binding.root)
diff --git a/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerActivityViewModel.kt b/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerActivityViewModel.kt
index c9be4d09..0c76d7c3 100644
--- a/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerActivityViewModel.kt
+++ b/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerActivityViewModel.kt
@@ -5,6 +5,7 @@ import android.os.Handler
 import android.os.Looper
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
+import androidx.lifecycle.SavedStateHandle
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
 import androidx.media3.common.AudioAttributes
@@ -44,6 +45,7 @@ constructor(
     private val application: Application,
     private val jellyfinRepository: JellyfinRepository,
     private val appPreferences: AppPreferences,
+    private val savedStateHandle: SavedStateHandle,
 ) : ViewModel(), Player.Listener {
     val player: Player
 
@@ -71,8 +73,8 @@ constructor(
 
     val trackSelector = DefaultTrackSelector(application)
     var playWhenReady = true
-    private var currentMediaItemIndex = 0
-    private var playbackPosition: Long = 0
+    private var currentMediaItemIndex = savedStateHandle["mediaItemIndex"] ?: 0
+    private var playbackPosition: Long = savedStateHandle["position"] ?: 0
 
     var playbackSpeed: Float = 1f
     var disableSubtitle: Boolean = false
@@ -116,6 +118,10 @@ constructor(
     fun initializePlayer(
         items: Array<PlayerItem>,
     ) {
+        // Skip initialization when there are already items
+        if (this.items.isNotEmpty()) {
+            return
+        }
         this.items = items
         player.addListener(this)
 
@@ -156,10 +162,16 @@ constructor(
                 Timber.e(e)
             }
 
+            val startPosition = if (playbackPosition == 0L) {
+                items.getOrNull(currentMediaItemIndex)?.playbackPosition ?: C.TIME_UNSET
+            } else {
+                playbackPosition
+            }
+
             player.setMediaItems(
                 mediaItems,
                 currentMediaItemIndex,
-                items.getOrNull(currentMediaItemIndex)?.playbackPosition ?: C.TIME_UNSET,
+                startPosition,
             )
             if (appPreferences.playerMpv) { // For some reason, adding a 1ms delay between these two lines fixes a crash when playing with mpv from downloads
                 withContext(Dispatchers.IO) {
@@ -191,9 +203,9 @@ constructor(
         }
 
         _currentTrickPlay.value = null
-        playWhenReady = player.playWhenReady
-        playbackPosition = position
-        currentMediaItemIndex = player.currentMediaItemIndex
+        playWhenReady = false
+        playbackPosition = 0L
+        currentMediaItemIndex = 0
         player.removeListener(this)
         player.release()
     }
@@ -201,6 +213,7 @@ constructor(
     private fun pollPosition(player: Player) {
         val playbackProgressRunnable = object : Runnable {
             override fun run() {
+                savedStateHandle["position"] = player.currentPosition
                 viewModelScope.launch {
                     if (player.currentMediaItem != null && player.currentMediaItem!!.mediaId.isNotEmpty()) {
                         val itemId = UUID.fromString(player.currentMediaItem!!.mediaId)
@@ -240,6 +253,7 @@ constructor(
 
     override fun onMediaItemTransition(mediaItem: MediaItem?, reason: Int) {
         Timber.d("Playing MediaItem: ${mediaItem?.mediaId}")
+        savedStateHandle["mediaItemIndex"] = player.currentMediaItemIndex
         viewModelScope.launch {
             try {
                 items.first { it.itemId.toString() == player.currentMediaItem?.mediaId }