From 7e4ac39e8354b25a2d0fea76a4579dfb4cbc790b Mon Sep 17 00:00:00 2001 From: Jarne Demeulemeester Date: Sat, 20 May 2023 15:25:57 +0200 Subject: [PATCH] perf: remove duplicate getMediaSources call when preparing player items --- .../java/dev/jdtech/jellyfin/viewmodels/PlayerViewModel.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerViewModel.kt b/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerViewModel.kt index 5ea0a18a..f3d7fc6e 100644 --- a/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerViewModel.kt +++ b/player/video/src/main/java/dev/jdtech/jellyfin/viewmodels/PlayerViewModel.kt @@ -136,10 +136,11 @@ class PlayerViewModel @Inject internal constructor( mediaSourceIndex: Int?, playbackPosition: Long ): PlayerItem { + val mediaSources = repository.getMediaSources(id, true) val mediaSource = if (mediaSourceIndex == null) { - repository.getMediaSources(id, true).firstOrNull { it.type == FindroidSourceType.LOCAL } ?: repository.getMediaSources(id, true)[0] + mediaSources.firstOrNull { it.type == FindroidSourceType.LOCAL } ?: mediaSources[0] } else { - repository.getMediaSources(id, true)[mediaSourceIndex] + mediaSources[mediaSourceIndex] } val externalSubtitles = mediaSource.mediaStreams .filter { mediaStream ->