From 97459686d472bd9e2dcf00877430627f0176b96a Mon Sep 17 00:00:00 2001
From: Jarne Demeulemeester <jarne.demeulemeester@student.howest.be>
Date: Tue, 15 Jun 2021 11:55:18 +0200
Subject: [PATCH] Improve layout for tablets

---
 app/src/main/res/layout/collection_item.xml        | 1 +
 app/src/main/res/layout/fragment_add_server.xml    | 2 +-
 app/src/main/res/layout/fragment_login.xml         | 2 +-
 app/src/main/res/layout/fragment_media.xml         | 5 +++--
 app/src/main/res/layout/fragment_server_select.xml | 2 +-
 app/src/main/res/values-sw600dp/dimens.xml         | 6 ++++++
 app/src/main/res/values-sw720dp/dimens.xml         | 5 +++++
 app/src/main/res/values/dimens.xml                 | 8 ++++++++
 8 files changed, 26 insertions(+), 5 deletions(-)
 create mode 100644 app/src/main/res/values-sw600dp/dimens.xml
 create mode 100644 app/src/main/res/values-sw720dp/dimens.xml
 create mode 100644 app/src/main/res/values/dimens.xml

diff --git a/app/src/main/res/layout/collection_item.xml b/app/src/main/res/layout/collection_item.xml
index 6567d0ec..182d7aba 100644
--- a/app/src/main/res/layout/collection_item.xml
+++ b/app/src/main/res/layout/collection_item.xml
@@ -14,6 +14,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="32dp"
+        android:layout_marginHorizontal="12dp"
         android:orientation="vertical">
 
         <com.google.android.material.imageview.ShapeableImageView
diff --git a/app/src/main/res/layout/fragment_add_server.xml b/app/src/main/res/layout/fragment_add_server.xml
index 957cebdd..b98c521b 100644
--- a/app/src/main/res/layout/fragment_add_server.xml
+++ b/app/src/main/res/layout/fragment_add_server.xml
@@ -31,7 +31,7 @@
 
         <LinearLayout
             android:id="@+id/linearLayout"
-            android:layout_width="match_parent"
+            android:layout_width="@dimen/setup_container_width"
             android:layout_height="wrap_content"
             android:layout_marginStart="24dp"
             android:layout_marginEnd="24dp"
diff --git a/app/src/main/res/layout/fragment_login.xml b/app/src/main/res/layout/fragment_login.xml
index 382d95c7..e146eb4e 100644
--- a/app/src/main/res/layout/fragment_login.xml
+++ b/app/src/main/res/layout/fragment_login.xml
@@ -29,7 +29,7 @@
 
         <LinearLayout
             android:id="@+id/linearLayout"
-            android:layout_width="match_parent"
+            android:layout_width="@dimen/setup_container_width"
             android:layout_height="wrap_content"
             android:layout_marginStart="24dp"
             android:layout_marginEnd="24dp"
diff --git a/app/src/main/res/layout/fragment_media.xml b/app/src/main/res/layout/fragment_media.xml
index a37743ec..192111af 100644
--- a/app/src/main/res/layout/fragment_media.xml
+++ b/app/src/main/res/layout/fragment_media.xml
@@ -31,14 +31,15 @@
             android:layout_width="match_parent"
             android:layout_height="0dp"
             android:clipToPadding="false"
-            android:paddingHorizontal="24dp"
+            android:paddingHorizontal="12dp"
             app:collections="@{viewModel.collections}"
-            app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
+            app:layoutManager="androidx.recyclerview.widget.GridLayoutManager"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="parent"
             tools:itemCount="4"
+            app:spanCount="@integer/collection_colums"
             tools:listitem="@layout/collection_item" />
     </androidx.constraintlayout.widget.ConstraintLayout>
 </layout>
diff --git a/app/src/main/res/layout/fragment_server_select.xml b/app/src/main/res/layout/fragment_server_select.xml
index 9c5a5ef2..b10630a0 100644
--- a/app/src/main/res/layout/fragment_server_select.xml
+++ b/app/src/main/res/layout/fragment_server_select.xml
@@ -61,7 +61,7 @@
                 app:layout_constraintTop_toBottomOf="@+id/image_banner"
                 app:layout_constraintVertical_bias="0.36"
                 app:servers="@{viewModel.servers}"
-                app:spanCount="3"
+                app:spanCount="@integer/server_colums"
                 tools:itemCount="4"
                 tools:listitem="@layout/server_item" />
         </LinearLayout>
diff --git a/app/src/main/res/values-sw600dp/dimens.xml b/app/src/main/res/values-sw600dp/dimens.xml
new file mode 100644
index 00000000..4baf068c
--- /dev/null
+++ b/app/src/main/res/values-sw600dp/dimens.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <dimen name="setup_container_width">400dp</dimen>
+    <item name="server_colums" type="integer">6</item>
+    <item name="collection_colums" type="integer">3</item>
+</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values-sw720dp/dimens.xml b/app/src/main/res/values-sw720dp/dimens.xml
new file mode 100644
index 00000000..9cec95f0
--- /dev/null
+++ b/app/src/main/res/values-sw720dp/dimens.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <item name="server_colums" type="integer">8</item>
+    <item name="collection_colums" type="integer">4</item>
+</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
new file mode 100644
index 00000000..bc6448a9
--- /dev/null
+++ b/app/src/main/res/values/dimens.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <item name="match_parent" type="dimen">-1</item>
+    <item name="wrap_content" type="dimen">-2</item>
+    <dimen name="setup_container_width">@dimen/match_parent</dimen>
+    <item name="server_colums" type="integer">3</item>
+    <item name="collection_colums" type="integer">1</item>
+</resources>
\ No newline at end of file