From ce1fe7edfc0c7f38c51a8befe308277f660258a3 Mon Sep 17 00:00:00 2001
From: Cd16d <98320806+cd16b@users.noreply.github.com>
Date: Fri, 23 Jun 2023 16:11:22 +0200
Subject: [PATCH] fix: missing/hardcoded strings (#415)

* fix: add missing/hardcoded strings

* Update strings.xml
---
 .../src/main/res/layout/exo_main_controls.xml | 24 ++++++++++++-------
 player/video/src/main/res/values/strings.xml  |  9 +++++++
 2 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/app/phone/src/main/res/layout/exo_main_controls.xml b/app/phone/src/main/res/layout/exo_main_controls.xml
index ab433f16..c46480ce 100644
--- a/app/phone/src/main/res/layout/exo_main_controls.xml
+++ b/app/phone/src/main/res/layout/exo_main_controls.xml
@@ -63,7 +63,7 @@
                 android:layout_gravity="end"
                 android:layout_weight="1"
                 android:background="@drawable/transparent_circle_background"
-                android:contentDescription="Locks the player"
+                android:contentDescription="@string/player_controls_lock"
                 android:padding="16dp"
                 android:src="@drawable/ic_lock"
                 app:tint="@android:color/white" />
@@ -132,7 +132,8 @@
             android:layout_marginEnd="32dp"
             android:background="@drawable/transparent_circle_background"
             android:padding="16dp"
-            android:src="@drawable/ic_skip_back" />
+            android:src="@drawable/ic_skip_back"
+            android:contentDescription="@string/player_controls_skip_back" />
 
         <ImageButton
             android:id="@+id/exo_rew"
@@ -141,7 +142,8 @@
             android:layout_marginEnd="32dp"
             android:background="@drawable/transparent_circle_background"
             android:padding="16dp"
-            android:src="@drawable/ic_rewind" />
+            android:src="@drawable/ic_rewind"
+            android:contentDescription="@string/player_controls_rewind" />
 
         <ImageButton
             android:id="@+id/exo_play_pause"
@@ -151,7 +153,8 @@
             android:backgroundTint="@android:color/white"
             android:padding="16dp"
             android:src="@drawable/ic_play"
-            app:tint="@android:color/black" />
+            app:tint="@android:color/black"
+            android:contentDescription="@string/player_controls_play_pause" />
 
         <ImageButton
             android:id="@+id/exo_pause"
@@ -162,7 +165,8 @@
             android:padding="16dp"
             android:src="@drawable/ic_pause"
             android:visibility="gone"
-            app:tint="@android:color/black" />
+            app:tint="@android:color/black"
+            android:contentDescription="@string/player_controls_pause" />
 
         <ImageButton
             android:id="@+id/exo_ffwd"
@@ -171,7 +175,8 @@
             android:layout_marginStart="32dp"
             android:background="@drawable/transparent_circle_background"
             android:padding="16dp"
-            android:src="@drawable/ic_fast_forward" />
+            android:src="@drawable/ic_fast_forward"
+            android:contentDescription="@string/player_controls_fast_forward" />
 
         <ImageButton
             android:id="@+id/exo_next"
@@ -180,7 +185,8 @@
             android:layout_marginStart="32dp"
             android:background="@drawable/transparent_circle_background"
             android:padding="16dp"
-            android:src="@drawable/ic_skip_forward" />
+            android:src="@drawable/ic_skip_forward"
+            android:contentDescription="@string/player_controls_skip_forward" />
     </LinearLayout>
 
     <LinearLayout
@@ -197,7 +203,8 @@
             android:layout_gravity="start"
             android:background="@android:color/transparent"
             android:visibility="gone"
-            tools:visibility="visible" />
+            tools:visibility="visible"
+            android:contentDescription="@string/player_trickplay" />
 
         <LinearLayout
             android:layout_width="wrap_content"
@@ -242,6 +249,7 @@
             android:id="@+id/exo_progress"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
+            android:contentDescription="@string/player_controls_progress"
             app:played_color="?attr/colorPrimary" />
 
     </LinearLayout>
diff --git a/player/video/src/main/res/values/strings.xml b/player/video/src/main/res/values/strings.xml
index 9103e965..6ac7745f 100644
--- a/player/video/src/main/res/values/strings.xml
+++ b/player/video/src/main/res/values/strings.xml
@@ -4,4 +4,13 @@
     <string name="select_playback_speed">Select playback speed</string>
     <string name="select_a_version">"Select a version"</string>
     <string name="external">External</string>
+    <string name="player_controls_lock">Locks the player</string>
+    <string name="player_controls_skip_back">Skip back</string>
+    <string name="player_controls_rewind">Rewind</string>
+    <string name="player_controls_play_pause">Play pause</string>
+    <string name="player_controls_pause">Pause</string>
+    <string name="player_controls_fast_forward">Fast forward</string>
+    <string name="player_controls_skip_forward">Skip forward</string>
+    <string name="player_trickplay">Trickplay</string>
+    <string name="player_controls_progress">Progress bar</string>
 </resources>