refactor: remove databinding from favorite_section, next_up_section and view_item

app/phone/src/main/java/dev/jdtech/jellyfin/BindingAdapters.kt

@@ -4,10 +4,7 @@ import android.view.View
 import android.widget.ImageView
 import androidx.annotation.DrawableRes
 import androidx.databinding.BindingAdapter
-import androidx.recyclerview.widget.RecyclerView
 import coil.load
-import dev.jdtech.jellyfin.adapters.HomeEpisodeListAdapter
-import dev.jdtech.jellyfin.adapters.ViewItemListAdapter
 import dev.jdtech.jellyfin.api.JellyfinApi
 import dev.jdtech.jellyfin.models.FindroidEpisode
 import dev.jdtech.jellyfin.models.FindroidItem
@@ -20,12 +17,6 @@ import org.jellyfin.sdk.model.api.ImageType
 import java.util.UUID
 import dev.jdtech.jellyfin.core.R as CoreR
 
-@BindingAdapter("items")
-fun bindItems(recyclerView: RecyclerView, data: List<FindroidItem>?) {
-    val adapter = recyclerView.adapter as ViewItemListAdapter
-    adapter.submitList(data)
-}
-
 @BindingAdapter("itemImage")
 fun bindItemImage(imageView: ImageView, item: BaseItemDto) {
     val itemId =
@@ -69,12 +60,6 @@ fun bindPersonImage(imageView: ImageView, person: BaseItemPerson) {
         .posterDescription(person.name)
 }
 
-@BindingAdapter("homeEpisodes")
-fun bindHomeEpisodes(recyclerView: RecyclerView, data: List<FindroidItem>?) {
-    val adapter = recyclerView.adapter as HomeEpisodeListAdapter
-    adapter.submitList(data)
-}
-
 @BindingAdapter("cardItemImage")
 fun bindCardItemImage(imageView: ImageView, item: FindroidItem) {
     val imageType = when (item) {

app/phone/src/main/java/dev/jdtech/jellyfin/adapters/FavoritesListAdapter.kt

@@ -20,7 +20,6 @@ class FavoritesListAdapter(
             onClickListener: ViewItemListAdapter.OnClickListener,
             onEpisodeClickListener: HomeEpisodeListAdapter.OnClickListener,
         ) {
-            binding.section = section
             if (section.id == Constants.FAVORITE_TYPE_MOVIES || section.id == Constants.FAVORITE_TYPE_SHOWS) {
                 binding.itemsRecyclerView.adapter =
                     ViewItemListAdapter(onClickListener, fixedWidth = true)
@@ -31,7 +30,6 @@ class FavoritesListAdapter(
                 (binding.itemsRecyclerView.adapter as HomeEpisodeListAdapter).submitList(section.items)
             }
             binding.sectionName.text = section.name.asString(binding.root.resources)
-            binding.executePendingBindings()
         }
     }
 

app/phone/src/main/java/dev/jdtech/jellyfin/adapters/ViewListAdapter.kt

@@ -31,24 +31,22 @@ class ViewListAdapter(
             onItemClickListener: ViewItemListAdapter.OnClickListener,
         ) {
             val view = dataItem.view
-            binding.view = view
             binding.viewName.text = binding.viewName.context.resources.getString(CoreR.string.latest_library, view.name)
             binding.itemsRecyclerView.adapter =
                 ViewItemListAdapter(onItemClickListener, fixedWidth = true)
+            (binding.itemsRecyclerView.adapter as ViewItemListAdapter).submitList(view.items)
             binding.viewAll.setOnClickListener {
                 onClickListener.onClick(view)
             }
-            binding.executePendingBindings()
         }
     }
 
     class NextUpViewHolder(private var binding: NextUpSectionBinding) :
         RecyclerView.ViewHolder(binding.root) {
         fun bind(section: HomeItem.Section, onClickListener: HomeEpisodeListAdapter.OnClickListener) {
-            binding.section = section.homeSection
             binding.sectionName.text = section.homeSection.name.asString(binding.sectionName.context.resources)
             binding.itemsRecyclerView.adapter = HomeEpisodeListAdapter(onClickListener)
-            binding.executePendingBindings()
+            (binding.itemsRecyclerView.adapter as HomeEpisodeListAdapter).submitList(section.homeSection.items)
         }
     }
 

app/phone/src/main/res/layout/favorite_section.xml

@@ -1,20 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
-<layout xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:tools="http://schemas.android.com/tools">
+    xmlns:tools="http://schemas.android.com/tools"
-
-    <data>
-
-        <variable
-            name="section"
-            type="dev.jdtech.jellyfin.models.FavoriteSection" />
-    </data>
-
-    <LinearLayout
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-        android:orientation="vertical"
+    android:layout_marginBottom="12dp"
-        android:layout_marginBottom="12dp">
+    android:orientation="vertical">
 
     <TextView
         android:id="@+id/section_name"
@@ -35,5 +26,4 @@
         android:paddingHorizontal="12dp"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
         tools:listitem="@layout/home_episode_item" />
-    </LinearLayout>
+</LinearLayout>
-</layout>

app/phone/src/main/res/layout/next_up_section.xml

@@ -1,20 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
-<layout xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:tools="http://schemas.android.com/tools">
+    xmlns:tools="http://schemas.android.com/tools"
-
-    <data>
-
-        <variable
-            name="section"
-            type="dev.jdtech.jellyfin.models.HomeSection" />
-    </data>
-
-    <LinearLayout
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-        android:orientation="vertical"
+    android:layout_marginBottom="12dp"
-        android:layout_marginBottom="12dp">
+    android:orientation="vertical">
 
     <TextView
         android:id="@+id/section_name"
@@ -33,8 +24,6 @@
         android:clipToPadding="false"
         android:orientation="horizontal"
         android:paddingHorizontal="12dp"
-            app:homeEpisodes="@{section.items}"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
         tools:listitem="@layout/home_episode_item" />
-    </LinearLayout>
+</LinearLayout>
-</layout>

app/phone/src/main/res/layout/view_item.xml

@@ -1,16 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
-<layout xmlns:android="http://schemas.android.com/apk/res/android"
+<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:tools="http://schemas.android.com/tools">
+    xmlns:tools="http://schemas.android.com/tools"
-
-    <data>
-
-        <variable
-            name="view"
-            type="dev.jdtech.jellyfin.models.View" />
-    </data>
-
-    <androidx.constraintlayout.widget.ConstraintLayout
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:layout_marginBottom="12dp">
@@ -47,12 +38,9 @@
         android:clipToPadding="false"
         android:orientation="horizontal"
         android:paddingHorizontal="12dp"
-            app:items="@{view.items}"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/view_name"
         tools:listitem="@layout/base_item" />
-    </androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>
-
-</layout>