308d97068f
* Refactor playback code * Fix back state when playing media and rotating device Problem was playerItems were re-emitted on fragment creation after config change. LiveData by design emit on every subscribe (observe) so to avoid that there are several possibilities. 1) easiest, observe playerItems not in onCreate but in playButton.clickListener. Stupid, since then we need to remember to only observe in this special place. 2) SingleLiveData - kind of hacky since LiveData were designed to behave this way so we don't want to go against their design. 3) Use Kotlin flow instead. I chose the flow approach since it's Kotlin native and modern way to do things and behaves much more Rx-like. Since now we need to call collect instead of observe and launch in coroutine, I added utility method to make this easier. Also, in the future we might want to improve this further, either by coming up with new way entirely or by at least moving this to parent fragment from which all fragments that want to play media will inherit and thus making it easy to use and maintain. Co-authored-by: Jarne Demeulemeester <32322857+jarnedemeulemeester@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| libs | ||
| src | ||
| .gitignore | ||
| build.gradle.kts | ||
| proguard-rules.pro | ||